Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 12 pull requests #76678

Merged
merged 28 commits into from
Sep 14, 2020
Merged

Rollup of 12 pull requests #76678

merged 28 commits into from
Sep 14, 2020

Conversation

jonas-schievink
Copy link
Contributor

Successful merges:

Failed merges:

r? @ghost

jyn514 and others added 28 commits September 7, 2020 07:58
Looks like it is no longer necessary, as uninit_array() can be used
instead in the few cases where it was needed.
Without this, it was not inlined in SyncOnceCell::into_inner(), causing
unecessary checks and dead code.
This note is not relevant to other operating systems.
It took me quite some time to figure out what Span::to means.
A picture is worth a thousand words.
unions: test move behavior of non-Copy fields

This test ensures the behaviors suggested by @petrochenkov [here](#32836 (comment)).
Note that parallel-compiler = true causes tests to fail

Mentioning #75760.
…onas-schievink

Remove internal and unstable MaybeUninit::UNINIT.

Looks like it is no longer necessary, as `uninit_array()` can be used instead in the few cases where it was needed.

(I wanted to just add `#[doc(hidden)]` to remove clutter from the documentation, but looks like it can just be removed entirely.)
…r=matklad

Simplify SyncOnceCell's `take` and `drop`.

Prevents copies by using `assume_init_read` and `assume_init_drop`.
…=Mark-Simulacrum

Remove Windows details from Unix and VmWorks symlink() docstrings

This note is not relevant to other operating systems.
slice::from_raw_parts: explicitly mention that data must be initialized

This reflects the status quo, until the discussion in rust-lang/unsafe-code-guidelines#77 reaches a conclusion.
Fix CI LLVM to work on NixOS out of the box

r? @Mark-Simulacrum

Tested locally, seems to work!
Add visualization of rustc span in doc

It took me quite some time to figure out what Span::to means.
A picture is worth a thousand words.
note that test_stable_pointers does not reflect a stable guarantee

Just to be sure...
@jonas-schievink
Copy link
Contributor Author

@bors r+ p=12 rollup=never

@bors
Copy link
Contributor

bors commented Sep 13, 2020

📌 Commit fe716d0 has been approved by jonas-schievink

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 13, 2020
@jonas-schievink jonas-schievink added the rollup A PR which is a rollup label Sep 13, 2020
@bors
Copy link
Contributor

bors commented Sep 13, 2020

⌛ Testing commit fe716d0 with merge f9a322a...

@bors
Copy link
Contributor

bors commented Sep 14, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: jonas-schievink
Pushing f9a322a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 14, 2020
@bors bors merged commit f9a322a into rust-lang:master Sep 14, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants